From 9497edf1994854abb18b50f342ef1dc3e0349c17 Mon Sep 17 00:00:00 2001 From: xisco Date: Fri, 15 May 2020 17:52:06 +0200 Subject: [PATCH] add check for maxTweetsNbr and rename GetSearchTweets fun to Search Tweets --- search.go | 6 +++--- search_test.go | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/search.go b/search.go index 2fded71..28aa6ea 100644 --- a/search.go +++ b/search.go @@ -9,8 +9,8 @@ import ( const ajaxSearchURL = "https://twitter.com/i/search/timeline?q=%s" -// GetTweets returns channel with tweets for a given search query -func GetSearchTweets(query string, maxTweetsNbr int) <-chan *Result { +// SearchTweets returns channel with tweets for a given search query +func SearchTweets(query string, maxTweetsNbr int) <-chan *Result { channel := make(chan *Result) go func(query string) { defer close(channel) @@ -40,7 +40,7 @@ func GetSearchTweets(query string, maxTweetsNbr int) <-chan *Result { return channel } -// FetchTweets gets tweets for a given search query, via the Twitter frontend API +// FetchSearchTweets gets tweets for a given search query, via the Twitter frontend API func FetchSearchTweets(query, maxId string) ([]*Tweet, error) { if maxId != "" { query = query + " max_id:" + maxId diff --git a/search_test.go b/search_test.go index bb0a771..23e8872 100644 --- a/search_test.go +++ b/search_test.go @@ -4,7 +4,8 @@ import "testing" func TestGetSearchTweets(t *testing.T) { count := 0 - for tweet := range GetSearchTweets("twitter scraper data -filter:retweets", 50) { + maxTweetsNbr := 50 + for tweet := range SearchTweets("twitter scraper data -filter:retweets", maxTweetsNbr) { if tweet.Error != nil { t.Error(tweet.Error) } else { @@ -30,7 +31,7 @@ func TestGetSearchTweets(t *testing.T) { } } - if count == 0 { - t.Error("Expected tweets count is greater than zero") + if count != maxTweetsNbr { + t.Errorf("Expected tweets count=%v, got: %v", maxTweetsNbr, count) } }